Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

feat: better error message when reader feather v1 #1528

Merged
merged 3 commits into from
Aug 6, 2023
Merged

feat: better error message when reader feather v1 #1528

merged 3 commits into from
Aug 6, 2023

Conversation

ritchie46
Copy link
Collaborator

ritchie46
ritchie46 commented Aug 6, 2023
View reviewed changes
src/ffi/array.rs
@@ -235,9 +235,14 @@ unsafe fn create_buffer<T: NativeType>(
owner: InternalArrowArray,
index: usize,
) -> Result<Buffer<T>> {
let len = buffer_len(array, data_type, index)?;

if len == 0 {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c++ arrow can create null pointers when arrays are empty. This ensures we don't have to deal with that.

@ritchie46 ritchie46 mentioned this pull request Aug 6, 2023
Closed
@codecov
Copy link

codecov bot commented Aug 6, 2023 •
edited
Loading

Codecov Report

Patch coverage: 73.68% and project coverage change: -0.02% ⚠️

Comparison is base (d5c78e7) 83.45% compared to head (95f7758) 83.43%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
- Coverage   83.45%   83.43%   -0.02%     
==========================================
  Files         388      388              
  Lines       42128    42137       +9     
==========================================
  Hits        35159    35159              
- Misses       6969     6978       +9
Files Changed Coverage Δ
src/io/ipc/mod.rs 100.00% <ø> (ø)
src/io/ipc/read/file.rs 95.59% <40.00%> (-0.84%) ⬇️
src/ffi/array.rs 84.27% <77.77%> (-0.02%) ⬇️
src/io/ipc/read/file_async.rs 72.01% <100.00%> (ø)
src/io/ipc/write/file_async.rs 81.75% <100.00%> (ø)
src/io/ipc/write/writer.rs 89.92% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 92050ec into jorgecarleitao:main Aug 6, 2023
24 of 25 checks passed
@ritchie46 ritchie46 deleted the feather branch August 6, 2023 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ritchie46